Merge cov-core and pytest-cov packages and other fixes #58

ionelmc · 2015-06-30T18:22:21Z

First, I'm terribly sorry to make a PR like this, I got a bit impatient and there wasn't any activity on pytest-cov for a while so I made a fork. This PR includes the changes from that fork. Please don't send me back to the loony bin 😁

Changes I did and some of the goals behind them:

Keep the same arguments as for pytest-cov 1.x. No breaking changes, but still bring in the fixes regarding .coveragerc handling:
- Using bare --cov will use the sources specified in .coveragerc. Handling here. This means the --cov-source option from the 2.0 branch is gone.
- Using --cov-report=term will report missing lines if .coveragerc has show_missing = True
- The option --cov-fail-under is automatically activated if .coveragerc has fail_under = ... (only if using coverage 4.0)
- The option --cov-min is renamed to --cov-fail-under to keep consistency with coverage docs (so that users will have an easier time finding the option).
Fix the .pth activation. I found a solution that works when installing from install, easy_install, wheels and develop. Uninstall also works, but only for wheels.
Some improvements for CI (separate testing with xdist and windows CI via AppVeyor)
Merging the cov-core and pytest-cov packages to simplify things like the release process or compatibility problems caused by mismatched versions. I took an opinionated turn here I know but there's value in focusing on a single test tool.

Todo

classifiers
update setup.py (remove "Forked from pytest-cov", maybe other fixes)
update LICENSE (re-add me as author, you can leave yours)
update changelog
update Acknowledgements in README
update release date (don't know it yet)
sort out command line options

schlamar · 2015-06-30T18:40:01Z

Using bare --cov will use the sources specified in .coveragerc. Handling here. This means the --cov-source option from the 2.0 branch is gone.

The reason for deprecating --cov with parameters is that per convention any command line parameter should have either arguments or no argument at all.

An alternative would be to keep the behavior as it is and introduce a new parameter - e.g. --covrc - which activates coverage and reads sources from .coveragerc.

Or another option would be to always activate the plugin if there is a .coveragerc file and provide an option to disable it, something like --cov-disable.

schlamar · 2015-06-30T18:41:25Z

Thanks for contributing, BTW. Looks very great in general 🍰

schlamar · 2015-06-30T18:42:56Z

Is there anything left from the todo list in #28 (minus the points which are obviously obsolete)?

ionelmc · 2015-06-30T18:45:02Z

The reason for deprecating --cov with parameters is that per convention any command line parameter should have either arguments or no argument at all. Another option would be to keep the behavior as it is and introduce a new parameter - e.g. --covrc - which activates coverage and reads sources from .coveragerc.

Or another option would be to always activate the plugin if there is a .coveragerc file and provide an option to disable it, something like --cov-disable.

I agree it's not the cleanest cmdline api. Had pytest-cov not been already released with this --cov bi-valence I'd agree 100% with you. However, it's already released - are we getting any serious advantages by making users change their commands?

ionelmc · 2015-06-30T18:47:12Z

Is there anything left from the todo list in #28 (minus the points which are obviously obsolete).

I think this it's missing:

update classifiers in setup.py

The rest should be fixed.

We might need to flatten out a bit the current changelog.

schlamar · 2015-06-30T18:47:50Z

Had pytest-cov not been already released with this --cov bi-valence I'd agree 100% with you.

It's not released yet, only pending in the 2.0 branch ;)

schlamar · 2015-06-30T18:51:41Z

update classifiers in setup.py

I guess we can use the classifiers from https://github.com/ionelmc/pytest-cover/blob/master/setup.py ?

ionelmc · 2015-06-30T18:54:00Z

It's not released yet, only pending in the 2.0 branch ;)

You are right. But what if we just add a --cov-enable option? (to avoid deprecating --cov=foobar). Hmmm, that's not pretty either ...

Do people want the --cov-source?

ionelmc · 2015-06-30T18:54:24Z

I guess we can use the classifiers from https://github.com/ionelmc/pytest-cover/blob/master/setup.py ?

Then it's fixed :)

schlamar · 2015-06-30T18:55:53Z

Or another option would be to always activate the plugin if there is a .coveragerc file and provide an option to disable it, something like --cov-disable.

I guess this is my favorite right now. Any thoughts or other ideas?

ionelmc · 2015-06-30T19:00:07Z

I guess this is my favorite right now. Any thoughts or other ideas?

I suspect explicit opt-out would annoy some people.

What disadvantages do we have with the dual --cov / --cov=path arguments?

schlamar · 2015-07-03T06:59:23Z

What disadvantages do we have with the dual --cov / --cov=path arguments?

I'll still think about it. :) But I guess the alternatives are not really better so we can leave it like this.

I've added some minor points as todo list to the first post. But in general it looks really great. I think we are almost good to go and can release this soon :)

…ith no sources specified).

…r library coverage.

… are properly applied.

…has show_missing=true. Ref #1.

… for `show_missing` option. This allows the `show_missing` specified in .coveragerc to be used. Ref #1.

…Ref #2.

…re 32/64bit variants).

ionelmc · 2015-07-04T11:51:09Z

Alright, I've fixed those and squashed a little bit the unforking changes.

schlamar · 2015-07-06T07:02:52Z

One last small thing: Rename tests/test_pytest_cover.py back :)

Then I'll merge everything back in master and have a last look before release.

Thank you for this great PR 🍰

schlamar · 2015-07-06T10:22:22Z

I'll do this on my own, merging it now.

Merge cov-core and pytest-cov packages and other fixes

ionelmc · 2015-07-06T10:24:43Z

Ah yes, I'm a bit slow today.

About releasing, this is what I usually do:

rm -rf dist build src/*.egg-info; python3.4 setup.py clean --all sdist && twine upload dist/*

schlamar mentioned this pull request Jun 30, 2015

[WIP] 2.0 #28

Merged

12 tasks

ionelmc added 17 commits July 4, 2015 13:05

Initial relayouting.

a793976

Move this.

906926d

More relayouting

ebc6a99

Complete project structure.

ecdf3bf

More corrections.

f1e0bd3

Update setup.py to have the new pth handling and layout support.

c9731ab

Remove --cov-source and fix --cov without arg to activate coverage (w…

a6c5fa6

…ith no sources specified).

Fix imports.

ca12e6b

Update readme about the --cov arg.

0fdd8a3

Packaging fixes.

a4a0d0a

Add missing deps.

d4681d5

Add pth files.

3dd5f86

Fix config.getvalue check.

9489bb5

Fix heading levels and correct names.

742baa7

Fix test on python 2.6.

a208b92

Remove un-necessary tox envs.

d935aa5

Update changelog and authorship.

d73b543

ionelmc added 19 commits July 4, 2015 14:15

Change a bit test_central_nonspecific and the test to actually trigge…

e6b3088

…r library coverage.

Reformat.

e74f7d7

Change a bit the test so the external code is non-stdlib.

7ee700f

Use a helper module in a different location to test that inclue paths…

2f9c530

… are properly applied.

Use new 4.0 release.

8c4c5b8

Test that --cov-report=term will report missing lines if .coveragerc …

098ed9b

…has show_missing=true. Ref #1.

If term-missing is not specified then use None instead of False…

9841727

… for `show_missing` option. This allows the `show_missing` specified in .coveragerc to be used. Ref #1.

Load default cov_min from [report]fail_under (if coverage is 4.0). …

97e4b22

…Ref #2.

Rename --cov-min to --cov-fail-under.

10a54f1

Update changelog. Closes #1. Closes #2.

90a6e35

Update skel a bit.

cbebaa3

Fix incorrect renaming.

076045f

Update changelog.

781a9e9

Unicodes

c25b996

Fix version.

2cfebe5

Bump version: 1.0.0 → 2.0.0

3439cf4

Unfork project (rename back to pytest-cov).

c1f29b5

Remove release date (not released yet).

87d77b2

Allow overriding interpreter from env (eg: for AppVeyor where there a…

a2cd060

…re 32/64bit variants).

ionelmc added 2 commits July 5, 2015 15:50

Remove some un-necessary cruft.

8c5859b

Extend the changelog with some of the changes mentioned in #28.

5b91aff

schlamar added a commit that referenced this pull request Jul 6, 2015

Merge pull request #58 from ionelmc/single-package-and-other-fixes

e03031d

Merge cov-core and pytest-cov packages and other fixes

schlamar merged commit e03031d into pytest-dev:2.0 Jul 6, 2015

This was referenced Jul 6, 2015

Uniformize & Vectorize badges #41

Closed

cov-core: uninstall leaves pth file behind #53

Closed

nedbat mentioned this pull request Jun 23, 2018

default support for $COVERAGE_PROCESS_START nedbat/coveragepy#378

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge cov-core and pytest-cov packages and other fixes #58

Merge cov-core and pytest-cov packages and other fixes #58

ionelmc commented Jun 30, 2015

schlamar commented Jun 30, 2015

schlamar commented Jun 30, 2015

schlamar commented Jun 30, 2015

ionelmc commented Jun 30, 2015

ionelmc commented Jun 30, 2015

schlamar commented Jun 30, 2015

schlamar commented Jun 30, 2015

ionelmc commented Jun 30, 2015

ionelmc commented Jun 30, 2015

schlamar commented Jun 30, 2015

ionelmc commented Jun 30, 2015

schlamar commented Jul 3, 2015

ionelmc commented Jul 4, 2015

schlamar commented Jul 6, 2015

schlamar commented Jul 6, 2015

ionelmc commented Jul 6, 2015

Merge cov-core and pytest-cov packages and other fixes #58

Merge cov-core and pytest-cov packages and other fixes #58

Conversation

ionelmc commented Jun 30, 2015

Todo

schlamar commented Jun 30, 2015

schlamar commented Jun 30, 2015

schlamar commented Jun 30, 2015

ionelmc commented Jun 30, 2015

ionelmc commented Jun 30, 2015

schlamar commented Jun 30, 2015

schlamar commented Jun 30, 2015

ionelmc commented Jun 30, 2015

ionelmc commented Jun 30, 2015

schlamar commented Jun 30, 2015

ionelmc commented Jun 30, 2015

schlamar commented Jul 3, 2015

ionelmc commented Jul 4, 2015

schlamar commented Jul 6, 2015

schlamar commented Jul 6, 2015

ionelmc commented Jul 6, 2015